add more incremental reuse test cases #37332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently doesn't work that well at all in terms of getting reuse afterwards, see rust-lang#37333. =)
nikomatsakis
changed the title
Member
|
@bors r+ |
Collaborator
|
📌 Commit 3dbf4d1 has been approved by |
Collaborator
|
⌛ Testing commit 3dbf4d1 with merge ea4b94d... |
bors
added a commit
that referenced
this pull request
Nov 1, 2016
…oerister add more incremental reuse test cases r? @michaelwoerister This is basically a port of the "private method in impl". It works better when it's a top-level fn. =)
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @michaelwoerister
This is basically a port of the "private method in impl". It works better when it's a top-level fn. =)